Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Progress Bar on Scroll Reveal #95

Merged
merged 5 commits into from
Oct 3, 2021
Merged

Added Progress Bar on Scroll Reveal #95

merged 5 commits into from
Oct 3, 2021

Conversation

asmitbm
Copy link
Contributor

@asmitbm asmitbm commented Oct 3, 2021 •
edited
Loading

What is the change?

Added progress bars on scroll reveal. Whenever user scrolls, the progress bars appears

Related issue?

closes: #57

How was it tested?

It was tested in my local environment

Checklist:

Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

  • Have you followed the Contribution Guidelineswhile contributing.
  • Have you checked there aren't other open Pull Requests for the same update/change?
  • Have you made corresponding changes to the documentation?
  • Have you tested the code before submission?
  • Have you formatted your code ? (You can use any html,css beautifier)
  • My changes generates no new warnings.
  • I'm Hacktoberfest'21 contributor.
  • I have commented my code, particularly in hard-to-understand areas.

GIF/video of the working of component you created:

gif

@github-actions github-actions bot requested a review from siddhi-244 October 3, 2021 06:34
@asmitbm
Copy link
Contributor Author

asmitbm commented Oct 3, 2021

Umm, I don't why the gif is not linked in the comment, can you check that in PR.

siddhi-244
siddhi-244 approved these changes Oct 3, 2021
View reviewed changes
Copy link
Owner

@siddhi-244 siddhi-244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work🎊🎊

@siddhi-244 siddhi-244 assigned siddhi-244 and asmitbm and unassigned siddhi-244 Oct 3, 2021
@siddhi-244 siddhi-244 added accepted Hacktoberfest This issue will be considered for Hacktoberfest 2021 Hacktoberfest'21 This issue will be considered for Hacktoberfest 2021 Hacktoberfest-accepted This represents hacktoberfest accepted prs labels Oct 3, 2021
@siddhi-244 siddhi-244 merged commit 2b173fa into siddhi-244:main Oct 3, 2021
@asmitbm asmitbm deleted the progress branch October 6, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddhi-244 siddhi-244 siddhi-244 approved these changes

Assignees

@asmitbm asmitbm

Labels
accepted Hacktoberfest This issue will be considered for Hacktoberfest 2021 Hacktoberfest'21 This issue will be considered for Hacktoberfest 2021 Hacktoberfest-accepted This represents hacktoberfest accepted prs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add progress bars on scroll reveal
2 participants
@asmitbm @siddhi-244